supabase / supabase-flutter / 35978129877

94%

push

github

fix(supabase_typegen): order the view copies of a foreign key deterministically (#1883)

## What

Mirrors [supabase/sdk#207](https://github.com/supabase/sdk/pull/207)
(SDK-1953) in the Dart port of `sortGeneratorMetadata`.

The relationship comparator compared only `foreign_key_name`,
`referenced_relation` and `referenced_columns`. The view expansion
copies one foreign key onto every view exposing it, so those copies tie
on all three and stayed in the order the view key dependency query
aggregated them in, which has no `ORDER BY`. The port pinned that with a
stable merge sort and the test "keeps the introspection order of
relationships that tie", so it matched postgrest-typegen 0.2.2 byte for
byte while both depended on query order. The comparator now breaks ties
on `referenced_schema`, `schema`, `relation` and `columns`, the same
keys in the same order as upstream, and the test asserts the same order
from two input orders.

- `test/fixtures/generator_metadata.json` regenerated with
`tool/regenerate_fixture.ts --source` pointing at the sdk#207 branch:
the only change is that the `author_stats` copy of
`books_author_id_fkey` now precedes the `books` one.
- Goldens regenerated: `Authors.relations` lists `authorStats` before
`books`, and the header now names the current package version.

## Pin

`postgrestTypegenRevision` stays at `postgrest-typegen-v0.2.2`. The
drift check compares the SQL builders, which are unchanged, so it passes
against both the pin and sdk `main`. The sort itself is not covered by
that check, which is why this change has to be mirrored by hand. Bump
the pin once the postgrest-typegen release containing sdk#207 is out.

## Tests

- `dart test` in `packages/supabase_typegen` with
`SUPABASE_TYPEGEN_PARITY_DATABASE_URL` set against a fresh `postgres:15`
seeded with `seed.sql`, introspected through the Supabase CLI 2.116: 196
tests pass, including the parity test against the regenerated fixture
and goldens.
- `dart analyze` clean, `dart... (continued)

6 of 6 new or added lines in 1 file covered. (100.0%)

8664 of 9526 relevant lines covered (90.95%)

4.86 hits per line