christophevg / schema-tools / 35977142946

73%

push

github

fix: windows compatibility for tests and file:// handling

The new CI matrix exposed real, pre-existing Windows bugs (old CI was
ubuntu-only). Three root causes, all fixed:

1. Invalid JSON escape sequences: test fixtures embedded raw OS paths
   into JSON sources ("$ref": "file:D:\a\..."); "\a" is not a valid
   escape. The asset fixture now returns an AssetPath (str) whose .uri
   is a proper file:/// URI (path.as_uri(), fragment kept as #delimiter,
   not percent-encoded); embedded $ref sites use .uri.

2. file:// URL handling: Reference._fetch built file URLs via
   urlparse._replace, which mangles Windows drive letters (file:D:\...).
   Now converts the parsed path back via url2pathname and re-encodes
   with Path.as_uri(), producing file:///D:/... on Windows. Relative
   refs resolve against the CWD as before (unchanged semantics).

3. UnicodeDecodeError in xml.load/namespaces: Path.read_text()/open()
   without encoding uses the platform locale (cp1252 on Windows),
   failing on UTF-8 content (U+2019 in invoice.xml). Both now pass
   encoding="utf-8" (same for yaml.load).

Local make check green; pushing to re-verify the full CI matrix.

🤖 Implemented together with Yoker.

265 of 380 branches covered (69.74%)

Branch coverage included in aggregate %.

4 of 6 new or added lines in 3 files covered. (66.67%)

884 of 1251 relevant lines covered (70.66%)

0.71 hits per line