kubernetes-sigs / lws / 35967827648

85%

Build Type

push

github

Committed by web-flow

Commit Message

Add bounded group recovery for LeaderWorkerSet (#877)

* feat(lws): add fail-fast restart budget and dns publish opt-in

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix(lws): reconcile failed condition on leader pod updates

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix(lws): persist group restart counts across leader recreate

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* docs(kep): align KEP-820 publishNotReadyAddresses default with implementation

publishNotReadyAddresses is a *bool that defaults to true (unset/absent
preserves the historical behavior where LWS-owned headless Services
publish not-ready addresses). Also documents the eager per-leader
headless Service creation that closes the init-phase DNS timing race.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix(lws): cap group restart counter growth and lock in publishNotReadyAddresses legacy default

- Only bump the group-restart-count annotation on the transition into the
  exhausted state (count == maxGroupRestarts). Repeated failure events from a
  crash-looping pod no longer grow the counter without bound or generate
  annotation patch churn on every event.
- Add a unit test for CreateHeadlessServiceIfNotExists covering the
  nil/unset -> true (historical hardcoded) default and the explicit
  true/false reconciliation on both create and update paths.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix(lws): converge restart counters and filter the leader-pod watch

Review feedback:
- The budget read path now takes max(persisted, pod-annotation) instead of
  treating persisted==0 as "absent", and syncLeaderRestartCountAnnotation
  only raises the pod annotation (never downgrades), so a lagging side of
  the non-atomic patch pair can never undercount the budget. Added unit
  tests for both drift directions.
- The leader-pod watch on the LWS reconciler now uses a predicate:
  create/delete events still enqueue, and updates enqueue only when the
  group-re... (continued)

Coverage Stats

313 of 451 new or added lines in 4 files covered. (69.4%)

2 existing lines in 2 files now uncovered.

5526 of 6563 relevant lines covered (84.2%)

38.25 hits per line