solidjs / solid / 35956812681

74%

main: 89%

push

github

feat(signals): interactions wait for the handler's promise; UNTRACKED_ASYNC_HANDLER (#3604)

* feat(signals): an interaction waits for its handler's promise; UNTRACKED_ASYNC_HANDLER names the dead click no hold could judge

`onClick={async () => setResult(await save())}` returns a promise and
continues past the interaction frame. The record settled `idle` the moment
the handler returned, so the wait the person experienced — the whole
round-trip — was invisible to every verdict: no root write before the
`await` means no hold opened, and SILENT_HOLD judges holds.

`withInteraction` now hands the handler's return value to the engine
(`AttributionHooks.interactionEnd(returned)`); a thenable keeps the
`InteractionEvent` open until it settles either way, capped at 10s so a
promise that never settles cannot pin a record. The record carries
`continuationMs` (handler return → settle) and `settledMs` covers it, so a
consumer's span spans the wait. Writes in the continuation run with no
frame on the stack and stay unattributed; only the duration is claimed.

At settle, `UNTRACKED_ASYNC_HANDLER` fires when the handler took no other
road: no write before the await (a pending flag or optimistic value is the
acknowledgement, and its hold is SILENT_HOLD's to judge) and no `action()`
step under the frame (an action's steps stay attributed across yields).
Hold thresholds, since it is the same wait; off with `holds: false`. The
message carries the two repairs: make the work an action, or write the
pending state first.

Size: the tier +65 B (the return value through the seam), the engine
+384 B (the wait, the cap timer, the check and its text); caps moved with
notes. RFC 08 and the skill guide document the code; the plan records D1
and D2 as decided.

Co-Authored-By: Claude via Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* test(signals): judge UNTRACKED_ASYNC_HANDLER's threshold on a test-owned clock

"stays quiet below the hold thres... (continued)

594 of 882 branches covered (67.35%)

Branch coverage included in aggregate %.

869 of 1132 relevant lines covered (76.77%)

24.89 hits per line