bleedingdeacons / integrity / 35950035554
91%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 16
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.508% (-0.07%) from 90.574%
35950035554

push

github

web-flow 
test: convert the suite to Pest 5 (#77)

Every test file is now a closure-based Pest spec except one PHPUnit class,
RestControllerConstantsTest, split out of RestControllerTest. Its two tests
define WP_DEBUG and INTEGRITY_ALLOW_INSECURE_TRANSPORT, which cannot be
undone, so they run in a separate process, and Pest refuses process isolation.
Pest runs the class as it is.

The seven controller suites that used #[RunTestsInSeparateProcesses] are
converted rather than kept as classes. They isolated only because each test
alias-mocked Unity\Plugin, a workaround from before Unity was on this suite's
classpath. Unity is autoloaded from the sibling checkout now, so they install
a Plugin around the container double with Unity's own
Plugin::setInstance(Plugin::create($container)) and clear it afterwards. The
global $wpdb two of them set is restored afterwards too.

Running those in-process exposed one leak isolation had hidden: HasLogger
memoises its channel per class, so tests/Pest.php resets it for
Integrity\Plugin and RestController before each test.

tests/bootstrap.php defines PHPUNIT_COMPOSER_INSTALL when missing, as
Pest's launcher does not and the separate-process child needs it.
composer test, test:unit and test:coverage now run pest.

342 -> 342 tests, 747 -> 754 assertions, 0 skipped either side. Line
coverage 2601 -> 2599 of 2886; the two lines are the ABSPATH guards in
Plugin.php and Utils/Mask.php, included before coverage starts. Suite time
about 3m -> about 70s locally, from the dropped process isolation.

2746 of 3034 relevant lines covered (90.51%)

4.59 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
47.37
-1.05% integrity/integrity/src/Plugin.php
1
93.75
-3.13% integrity/integrity/src/Utils/Mask.php
Jobs
ID Job ID Ran Files Coverage
1 35950035554.1 16
90.51
GitHub Action Run
Source Files on build 35950035554