solidjs / solid / 35946933371

74%

main: 89%

push

github

fix(web): drop name/exports from nested subpath manifests so they can't shadow the root map (#3627) (#3631)

`server-functions/dist/rich-args.js` imports `@solidjs/web/server-functions/client`
by bare name on purpose (externalizeSharedClient keeps the client instance
shared across export conditions). The nearest manifest to that file was
`server-functions/package.json`, carrying `"name": "@solidjs/web/server-functions"`
and an `exports` map with only ".". Resolvers that implement package
self-reference by prefix-matching the nearest manifest's `name` — Node's CJS
`trySelf`, oxc-resolver under Vite 8 / Rolldown — read the specifier as
subpath `./client` of that nested "package", found it unexported, and failed
without consulting the root map. Node ESM and Vite 7 compare the full package
name and fell through, which is why only Vite 8 broke.

All seven nested manifests (`server-functions`, `server-functions/rich-args`,
`frames`, `serialization`, `serialization/decode`, `storage`,
`performance-tracks`) now carry only what legacy `node10`-style resolvers read:
`main`/`module`/`types`, plus `type: "module"` (they are the nearest manifest
to the dist files and so decide their module format) and `sideEffects`. The
root `exports` map already defined every entry the nested maps had, with a
superset of conditions; it is the single authority.

A packaging test resolves every bare `@solidjs/web[/…]` specifier found in
each nested `dist/*.js` from a consumer-shaped install, through both Node's
ESM and CJS resolvers, and pins the manifests' shape.

Fixes #3627

Co-authored-by: Claude via Cursor <noreply@cursor.com>

594 of 882 branches covered (67.35%)

Branch coverage included in aggregate %.

870 of 1133 relevant lines covered (76.79%)

24.75 hits per line