AnimaLogica / kathikon / a6ded66e501706af576bdc510b53c29c01dda0d9-PR-61

97%

Build Type

Pull #61

github

Committed by thanos

Commit Message

The Elixir 1.20 / OTP 29 job on [run 35899527911](https://github.com/AnimaLogica/kathikon/actions/runs/35899527911) failed two tests. The other matrix jobs passed.

The concurrency test inserted an `:available` job on `:default` while the live dispatcher was still polling. The dispatcher claimed it first, so all 100 `claim_job/2` calls failed and the assertion saw 0 successes instead of 1. The test then cleared storage while that job was still running, `complete_job/3` returned `{:error, :not_found}`, and `emit_stop/3` had no clause for that tuple, so the `:default` dispatcher crashed. The dispatcher unit test also failed in `on_exit` because `GenServer.stop/1` ran after the linked process had already exited.

`Kathikon.ClaimTest` now pauses `:default` before inserting the job and resumes it afterward. `emit_stop/3`, `emit_failure/3`, and `emit_discard/3` return without telemetry when storage returns an error, so a missing job does not kill the dispatcher. The dispatcher test unlinks its process and ignores an already-dead stop.

`mix test test/kathikon/claim_test.exs test/kathikon/dispatcher_test.exs --seed 0` — 14 passed.

Pull Request Pull Request #61: The Elixir 1.20 / OTP 29 job on [run 35899527911](https://github.com/…

Coverage Stats

1 of 3 new or added lines in 1 file covered. (33.33%)

2 existing lines in 1 file now uncovered.

1450 of 1495 relevant lines covered (96.99%)

178.23 hits per line