solidjs / solid / 35925466936

73%

main: 89%

push

github

fix(signals): recompute preserves REACTIVE_DISPOSED set during the run (#3621) (#3625)

A memo that disposed its own root during its recompute came back alive:
recompute's finally rebuilt _flags from the ZOMBIE bit alone, dropping the
REACTIVE_DISPOSED that disposeChildren set reentrantly. isDisposed() read
false, refresh() re-ran it, and the reads after the dispose() call had
re-linked the dead node to its sources.

- recompute's finally mask (and updateIfNecessary's) carries REACTIVE_DISPOSED.
- A pass whose node died is void: clearDeps, retire the flight, close the
  attribution frame, return before the value publishes (a dead node freezes
  at its last committed value, #3024).
- Tests: recompute-preserves-disposed-3621.test.ts (memo/root, deps
  unlinked, value not committed, outside effect not fired, effect twin,
  parent-owner twin, non-reentrant control).
- Size: +72 B minified in the core floor (treeshake cap 26,230 -> 26,300);
  brotli caps ratcheted with notes for render+one signal (12.60 KB),
  hydrating+stores (31.30 KB), observe+attribution (29.05 KB).

Fixes #3621

Co-authored-by: Claude via Cursor <noreply@cursor.com>

594 of 882 branches covered (67.35%)

Branch coverage included in aggregate %.

870 of 1133 relevant lines covered (76.79%)

24.67 hits per line