FlexMeasures / flexmeasures / 35924750213

85%

push

github

Fix: default view for automations page (#2582)

* api/v3_0: accept "Automations" as a default asset view

Context:
- The asset breadcrumb offers Automations alongside the other asset views,
  so its pages show the same "Set as default view" checkbox.
- The endpoint behind that checkbox validated against a list that was never
  extended when the Automations view was added, so ticking it returned 422
  and the next asset click still opened Context.

Change:
- Added "Automations" to the accepted names, to the documented enum and to
  the endpoint's example values, and regenerated the OpenAPI spec.
- Recorded on the schema which list it has to stay in sync with, and why
  the set is closed: a stored name addresses a route on AssetCrudUI.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* ui/static: report a view preference the server refused

Context:
- Both view-preference helpers passed their response straight to json(),
  and fetch rejects only on a network-level failure, so a 4xx or 5xx was
  parsed and dropped: no toast, no console line, and the checkbox kept the
  tick the click had given it.
- The legend helper reloaded the page either way, so a refusal redrew the
  old setting and read as the toggle bouncing back.

Change:
- Extracted the error normalisation that confirmAndFetch already did into
  rejectIfNotOk, and gave both helpers that check.
- Read the body through extractApiErrorMessage, which the context and
  properties pages already use, so a validation error reaches the user as
  the fields it named rather than as "[object Object]".
- On a refusal, put the checkbox back to what the server still has and
  report that message as an error toast.
- Reload for the legend preference only once it was stored.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* api/v3_0/tests: cover storing a default asset view

Context:
- The endpoint had no test at all, which is how the Automations view could
  be left ... (continued)

1 of 1 new or added line in 1 file covered. (100.0%)

19602 of 22819 relevant lines covered (85.9%)

0.86 hits per line