solidjs / solid / 35909343148

74%

main: 89%

push

github

feat(dev): warn when an unscoped hole allocates hydration ids (#3567 follow-up) (#3620)

* feat(dev): warn when an unscoped hole allocates hydration ids (#3567 follow-up)

Dev-only diagnostic UNSCOPED_HOLE_ALLOCATED_IDS for the bare function-valued
identifier hole (const renderHead = () => props.header; <div>{renderHead}</div>),
ruled not scoped: JSX.Element excludes functions, so the shape is reached only
from JavaScript or through a cast. Both runtimes bracket an unscoped function
hole's evaluation with the counter's next id (dev-only
sharedConfig.devPeekNextContextId on both facades). The server reports when the
walk evaluated an allocating hole at a position other than the one it was
registered at; the client reports when the content it built in place moved the
counter and missed a server-rendered key. Zero bytes in prod/observe dists.

Co-authored-by: Claude via Cursor <noreply@cursor.com>

* perf(dev): take the unscoped-hole bracket only for escape wrappers

The ssr() loop read the counter's next id (a formatted string) around every
function hole; scope wrappers and group fns are never candidates. Gate the
bracket on the $reg carrier escapeLate sets, so a dev render pays one
property read per function hole. Prod/observe dists unchanged.

---------

Co-authored-by: Claude via Cursor <noreply@cursor.com>

596 of 884 branches covered (67.42%)

Branch coverage included in aggregate %.

1 of 3 new or added lines in 1 file covered. (33.33%)

870 of 1133 relevant lines covered (76.79%)

24.67 hits per line