Qiskit / qiskit / 35902338680

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Add access to `QkParam` types from the C API (#16936)

* Initial: Add `qk_param_kind` and `qk_param_as_int`.

* Test: Add testing for kind (exclude integer).

* Docs: Add docstring

* Docs: Add enum to docs

* Fix: Follow writer pattern for `qk_param_as_int`.

Co-authored-by: David F. Cohen <me@davidfcohen.com>

* Format: return values.

* Docs: Fix missing docs

* Fix: Make `Unknown` the `0` variant.

* Addressing review comments:
- Break down `qk_param_as_int`.
- Simplify `qk_param_kind` to only evaluate concrete types.

* Apply batched suggestions from code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Fix: Address more review comments
- Use tildes more consistently.
- Update docstring of ``qk_param_as_real`` to address Matt's note and remove mention of complex numbers in ``qk_param_as_int``.
- Update return value in ``qk_param_as_int`` docstring.
- Add `derive` traits to `ParamKind`.
- Do exhaustive matching of `Param` in `param_try_int` and ``qk_param_kind``.

* Fix: Documentation in release note

* Apply batched suggestions from code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Docs: Update docstring `qk_param_as_int`
Specify that it will also error if the parameter happens to be bound but contains a floating point or complex number.

* Test: Add python c ffi test for delay

* Fix: Revert `qk_param_as_real` lossy conversion

* Fix: Use `c_int64` as the chosen type.

* Fix: Use correct initializer.

* Apply batched suggestions from code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Test: Add test for parameter expression and casting invalid int.

* Lint: Use b'string

* Update test/python/capi/test_circuit.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: David F. Cohen <me@davidfcohen.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Julien Gacon <gaconju@gmail.com>

Coverage Stats

22 of 25 new or added lines in 2 files covered. (88.0%)

22 existing lines in 2 files now uncovered.

119502 of 135967 relevant lines covered (87.89%)

962213.79 hits per line