solidjs / solid / 35899635677

74%

main: 89%

Build Type

push

github

Committed by web-flow

Commit Message

fix(hydration): null owner takes the transparent path; hybrid latches for non-stream shapes (#3609) (#3616)

* fix(hydration): a null or id-less owner takes the transparent path in every facade (#3609)

While hydrating, createMemo / function-form createSignal (and the
optimistic, store, projection, error-boundary, loading-boundary and effect
facades) peeked the next child id off getOwner()!. With no owner
(runWithOwner(null, …)) that was childId(null) → TypeError (reading
'_config') and REACTIVITY_HALTED; under a detached root without an id it
was "Cannot get child id from owner without an id".

An ownerless or id-less node has no id counter to consume, so there is
nothing to hydrate positionally — the server serializes nothing for it
either (its owner.id guard). One predicate, noHydrationId() (the shape
lazyHydrationLookup already used), short-circuits every facade to the core
primitive, exactly like transparent: true. The check lives in the shared
hydrateSignalLike / hydrateStoreLike bodies (covering the optimistic and
projection wrappers that reach them through the adapter slots) and at the
boundary/effect facades.

hydrateSignalLike also honors options.transparent now, so function-form
createSignal / createOptimistic no longer peek (and adopt) the NEXT
sibling's serialized slot when marked transparent — MemoOptions.transparent
already documented that they compute live.

useHead's explicit { transparent: true } from #3600 stays as documentation
of intent.

Co-authored-by: Claude via Cursor <noreply@cursor.com>

* fix(hydration): hybrid latches for non-stream shapes — stores match memos

Maintainer ruling: `hybrid` is only for streams realistically. For a sync
or promise-shaped compute, `ssrSource: "hybrid"` now behaves exactly like
`"server"` in the store adapter (function-form createStore,
createOptimisticStore, createProjection): the serialized answer is adopted
and the compute does not re-run on the client — no refetch — until a
dependency chang... (continued)

Coverage Stats

595 of 878 branches covered (67.77%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 1 file covered. (100.0%)

13 existing lines in 1 file now uncovered.

869 of 1130 relevant lines covered (76.9%)

24.82 hits per line