kubernetes-sigs / lws / 35896985935

85%

push

github

Improving test coverage across the board  (#1074)

* Improving test coverage across the board and updating the coverage badge to point to the main branch

Signed-off-by: ahg-g <ahg@google.com>

* Fix setConditions silently dropping all conditions after the first change

setConditions accumulated its result with:

    shouldUpdate = shouldUpdate || setCondition(lws, condition)

setCondition mutates the status as a side effect, but Go short-circuits
`||`, so once shouldUpdate became true every remaining condition was never
applied.

Both updateConditions and updateStatusHash request
[UpdateInProgress, Progressing] mid-rollout, so Progressing was dropped and
only surfaced on a later reconcile. Integration tests did not catch this
because they poll conditions with Eventually{}.

Accumulate with an explicit if instead so every requested condition is
applied. Steady state is unchanged (the old code converged one reconcile
later); the fix only makes Progressing appear sooner.

Test expectations updated accordingly:
- TestSetConditionsAppliesOneConditionPerCall, which pinned the buggy
  behaviour, becomes TestSetConditionsAppliesEveryCondition and now asserts
  both conditions land in a single call and a second call is a no-op.
- TestUpdateConditions and TestUpdateStatusHash expect both Progressing and
  UpdateInProgress during a rollout.

* Add unit tests for the workload-scheduling reconcile path

failWorkloadScheduling, updateWorkloadSchedulingCondition and
NewLeaderWorkerSetReconciler had no unit coverage at all, and Reconcile was
only exercised by envtest integration tests, which the Coveralls job does
not run.

Cover the helpers directly and the spec.scheduling branch of Reconcile
end to end through a fake SchedulerProvider, asserting on what is persisted
to the API rather than on the in-memory object:

- the condition is written with the reason, message and observedGeneration
- an unchanged condition short-circuits before issuing a status update
- a fa... (continued)

7 of 8 new or added lines in 1 file covered. (87.5%)

5151 of 6039 relevant lines covered (85.3%)

39.58 hits per line