MapColonies / shigola / 5de968124

57%

master: 44%

push

github

ci: gate go vet and gofmt -s, and fix the vet findings (MAPCO-11498) (#36)

* test(cmd): check the coordinates TestFormatParse parses

A successful parse hit `continue` before the coordinate assertion, so
the test only ever checked errors. go vet reports the assertion as
unreachable (MAPCO-11498).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(register): stop copying an atlas through TestMaps cases

tcase carried an atlas.Atlas, which holds a mutex, and every case copied
it by value. No case ever set it. go vet reports the copies (MAPCO-11498).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cmd): buffer the channel the shutdown signal arrives on

signal.Notify never blocks on a send, so with an unbuffered channel a
SIGTERM that arrives before signalHandler is receiving is dropped and
the process does not shut down. Flagged by go vet (MAPCO-11498).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(prometheus): give Handler a pointer receiver like the rest

A value receiver copied the whole observer, sync.Once fields included,
on every call. Every other method already takes *observer, and only
*observer satisfies the observer interfaces. Flagged by go vet
(MAPCO-11498).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(env): name the fields of dict.ErrKeyType literals

An unkeyed literal of a type from another package breaks silently if
its fields are reordered. go vet's composites check flags it
(MAPCO-11498).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: fail on go vet findings and on gofmt -s violations

A static checks job runs gofmt -s over every tracked Go file outside
vendor/ and go vet over the tree. Both were clean only by convention,
and vet was not: four kinds of finding had accumulated (MAPCO-11498).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(contributing): list gofmt -s and go vet as required checks

Both now fail CI, so say so w... (continued)

0 of 9 new or added lines in 3 files covered. (0.0%)

6019 of 10608 relevant lines covered (56.74%)

121.32 hits per line