xapi-project / xen-api / 35879341864
79%
master: 79%

LAST BUILD BRANCH: asv/duplicate-sm
DEFAULT BRANCH: master
Ran
Jobs 1
Files 36
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.996%. Remained the same
35879341864

push

github

web-flow 
CP-312521 xapi: enable external authentication caching by default on … (#7274)

## Expected behaviour

External AD authentication caching should behave as follows:

| Scenario | AD cache |
|---|---|
| XS9 fresh install | **enabled** |
| XS8.4 fresh install | **disabled** |
| XS8.4 → XS9 upgrade | **preserved** — disabled by default, but stays
**enabled** if the admin had explicitly enabled it before upgrading |

## What was wrong

On a fresh install, caching ended up disabled. Two independent defaults
both resolved to the wrong value:

- **`create_pool_record` (`dbsync_master.ml`)** sets
`ext_auth_cache_enabled` when the pool row is first created on a fresh
install; it was hard-coded to `false`. Changed to `true` so a fresh
install has caching enabled.
- **The datamodel `default_value` for `ext_auth_cache_enabled`**
backfills the column on upgrades from releases that predate the field.
It was `true`; changed to `false` so those upgrades default to disabled.
Upgrades from releases that already have the field keep their stored
value, so an admin who had enabled it stays enabled.

Administrators can still toggle the setting at runtime via
`pool.set_ext_auth_cache_enabled`.

## Schema

Changing the datamodel `default_value` alters the datamodel schema hash,
so this bumps `schema_minor_vsn` and updates `last_known_schema_hash`.

3667 of 4642 relevant lines covered (79.0%)

0.79 hits per line

Jobs
ID Job ID Ran Files Coverage
1 python3.11 - 35879341864.1 36
79.0
GitHub Action Run
Source Files on build 35879341864