pulibrary / orangelight / 97b46277-f02c-4003-9c9b-468663262666

96%

Build Type

push

circleci

Committed by web-flow

Commit Message

Remove staff email and filter logs to remove circular references (#6224)

* Don't send staff emails for physical requests

* Fix remaining tests

* Update logic for annex_no_items

* Update recap_no_items and add on_shelf_no_items

* Add on_shelf_no_items service eligibility class

* Handle on_shelf_no_items better

* Add templates for on shelf no items

* Improve item type logic and add on_shelf_no_items spec

* Determine no_items status based on null_item

* Fix failing tests and rubocop/reek warnings

* Revert change to validators

* ignore reek warnings

* Fix last reek warning

* Fix test

---------

Co-authored-by: Ryan Laddusaw <rladdusaw@princeton.edu>

Coverage Stats

37 of 39 new or added lines in 8 files covered. (94.87%)

4 existing lines in 2 files now uncovered.

6452 of 6745 relevant lines covered (95.66%)

1412.9 hits per line