safe-global / safe-eth-py / 35859702309

94%

push

github

fix: Treat signatures recovering to the zero address as invalid (#2758)

EOA and eth_sign signatures that cannot be recovered get NULL_ADDRESS as
owner from get_signing_address, but is_valid() always returned True for
them. The Safe contract never accepts address(0) as a signer, so
is_valid() now returns False in that case, sync and async.

owner is cached for these types, as is_valid() now reads it and ECDSA
recovery is slow.

37 of 37 new or added lines in 2 files covered. (100.0%)

11508 of 12301 relevant lines covered (93.55%)

3.74 hits per line