gookit / rux / 35857494576

92%

push

github

fix(server): report the resolved listen address for port 0 / --open

Start already bound the listener explicitly, but Run() exposed the result only
through an exported field written from another goroutine, and it guessed how
long net.Listen takes by sleeping 50ms before running PostStart. A caller doing
`--port 0` plus `--open` could only read ":0" (or a racy value) and had no way
to build a usable URL.

- Start signals the real bind over an internal channel; Run waits on that
  signal instead of time.After(50ms), so PostStart hooks always observe the
  resolved address
- add ListenAddr/ListenPort/LocalURL/IsListening/WaitListening; WaitListening
  waits for the bind, or returns the startup error / ErrNotListening
- keep the documented Host/Port fields in sync with the resolved address
- LocalURL maps wildcard binds (:0, 0.0.0.0:0, [::]:0) onto 127.0.0.1, honors
  TLS, and returns "" while the port is not final
- tests for ephemeral ports, wildcard binds, hook visibility, bind/PreStart
  failures, and URL formatting; README + README.zh-CN document the flow

111 of 117 new or added lines in 1 file covered. (94.87%)

2852 of 3070 relevant lines covered (92.9%)

3.93 hits per line