IgniteUI / igniteui-angular / 35849594217

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(forms): Correct editor validity state (#17637)

* fix(forms): Correct editor validity state

A pending async validator painted the invalid style. `valid` is false
while validators run, and every editor mapped `valid ? VALID : INVALID`,
so the error style showed before the rule had answered. The decision now
lives one level up: `NgControlAdapter` exposes a `status` accessor
mirroring `FormControlStatus`, and `toInputState` maps it to
`IgxInputState` for all seven call sites. `status` is derived rather
than read from `NgControl.status`, which the Signal Forms interop
throws from on statuses it does not recognize (#17621).

`aria-required` stayed true after a conditional `required` rule turned
off. Angular pushes the field's `required` into the directive input
during the host view update pass, which runs after the adapter's root
effect has already read the stale attribute. Writing the attribute from
the `required` setter puts the final write after that read (#17620).

A field with no rules showed the valid state after switching
`[formField]`. The interop `NgControl` is created once per directive and
reused across switches, so the sticky "this field had rules" flag leaked
from the previous field. The flag is now cleared while the control is
pristine and untouched, which is the state the new field is observed in.
Switching to an already touched or dirty field keeps the stale flag;
there is no public way to detect that switch (#17619).

* fix(forms): Map pending status on the blur path

The time and date range pickers repaint validity on blur through a path
of their own, which still mapped `!valid` to `INVALID`. `valid` is false
while an async validator runs, so blurring painted the error style
before the rule had answered - the bug the status-change path was
already fixed for.

* fix(forms): Keep success state after first edit

With Signal Forms, a pristine field failing a custom rule was not
recorded as having rules. When the first edit satisfied the ... (continued)

Coverage Stats

15487 of 17817 branches covered (86.92%)

Branch coverage included in aggregate %.

49 of 50 new or added lines in 7 files covered. (98.0%)

1 existing line in 1 file now uncovered.

31201 of 33415 relevant lines covered (93.37%)

38072.12 hits per line