urwid / urwid / 35842555077

93%

push

github

Make Text's line translation cache safe for concurrent readers (#1338)

Text kept the cached width and the cached translation in two attributes
written one after the other, and get_line_translation read them
separately. Button shares its button_left/button_right Text widgets at
class level, so two threads laying out buttons at once could read the
new width before its translation existed (AttributeError) or get the
translation laid out for the other thread's width.

The pair is now one (maxcol, translation) tuple read once, and
_update_cache_translation returns what it just computed instead of
re-reading the attribute. A regression test drives one Text from six
threads with a forced tiny switch interval; it fails on the previous
code under both the GIL and free-threaded builds.

4380 of 5386 branches covered (81.32%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

11112 of 12870 relevant lines covered (86.34%)

8.88 hits per line