IgniteUI / igniteui-angular / 35841019937

91%

push

github

fix(migrations): keep brackets balanced when updating theme properties (#17643)

* fix(migrations): keep brackets balanced when updating theme properties

`updateThemeProps` matched the owner call with a non paren-aware
`owner\([\s\S]+?\);` regex, so for a theme nested in another call -
`@include scrollbar(scrollbar-theme($sb-size: 6px))` - the match swallowed
the closing bracket of the surrounding call. That bracket ended up riding on
the last argument and was dropped together with it whenever the last (or the
only) argument was removed, leaving invalid SCSS behind:

    @include scrollbar(scrollbar-theme();

Locate the call's own closing bracket by scanning and counting brackets
instead, skipping strings and comments, and splice the rewritten argument
list in by index. This also lets a theme call that is not terminated by `;`
on the same statement be migrated.

Closes #17642

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(migrations): escape every `$` before building the property regex

`$` is a regex anchor, so the single-occurrence `replace` the escaping
relied on was incomplete. Flagged by CodeQL (js/incomplete-sanitization).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(migrations): use the shared escapeRegExp for the theme property regex

The hand-rolled `$` escaping was incomplete either way - CodeQL flagged the
single-occurrence replace, then the unescaped backslash. The file already
imports `escapeRegExp` from ./util and uses it elsewhere, so reuse it here
rather than keeping a partial escape of our own.

No behavior change: a theme property name only ever contains `$` and `-`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(migrations): skip strings and comments when looking for a theme call

`findFunctionCalls` located the opening `owner(` with a plain `indexOf`, so a
theme function merely mentioned in a comment or a quoted value was taken for a
real ca... (continued)

15503 of 17840 branches covered (86.9%)

Branch coverage included in aggregate %.

31200 of 33417 relevant lines covered (93.37%)

38062.98 hits per line