safe-global / safe-eth-py / 35837464278

94%

push

github

fix: Wrap transport errors in the library's own exception types (#2753)

* fix: Wrap transport errors in the library's own exception types

The raw JSON-RPC call sites of EthereumClient and AsyncEthereumClient
leaked requests and aiohttp exceptions, so callers had to import the HTTP
library to handle a node being down.

Each call site now raises the exception it already raised for a non ok
response, with the original exception kept as the cause:

- batch_call_custom: EthereumClientConnectionException, a new type that also
  inherits from the builtin ConnectionError, so callers catching the previous
  ConnectionError keep working
- Erc20Manager.get_info: InvalidERC20Info
- raw_batch_request: EthereumClientConnectionException, which is a ValueError

wrap_http_exceptions lives in safe_eth.util.http next to prepare_http_session.
It covers both transports and the JSON decoding of the response, which fails
the same way when a proxy answers with HTML.

* fix: Say querying instead of connecting in the wrapped error message

The wrapper also covers responses that cannot be decoded, which happen after
the connection succeeded.

95 of 102 new or added lines in 6 files covered. (93.14%)

11480 of 12272 relevant lines covered (93.55%)

1.87 hits per line