kubernetes-sigs / azuredisk-csi-driver / 35814997299

74%

Build Type

push

github

Committed by web-flow

Commit Message

Feature: QAD - NodeDriven attach (#3825)

* Initial changes for host based attach and detach

* Initial changes to enable QAD integration

* Changes that work

* cleanup

* Prevent case mismatch on Get disks call

* Add latency numbers

* test: testing files and updates

* fix: qad check

* chore: add statefulset test file

* Added error codes, changed blobURL and token handling

* Send managed identity token to the wireserver API

* Latest changes that work

* Call the BeginGrantAccess API

* Modify the e2e tests to allow running tests for QAD

* Sanitize BlobUR to ensure the attach/detach works

* Error handling changes

* Implement batching

* Remove the temporary testing changes

* Small cleanup change

* Implement claim/unclaim resource API

* Fixed comments

* remove QAD batcher

* other fixes

* better engineering

* fix(nodeserver): treat missing PV as non-QAD in NodeStageVolume

Align NodeStageVolume with the existing NodeUnstageVolume convention:
if getPVFromDiskURI returns errPVNotFound, fall back to the non-QAD
LUN resolution path instead of failing with an Internal error.

* better engineering

(cherry picked from commit bdd3dae19)

* fix(nodeserver): run Kata idempotency check before QAD PV lookup

Move the Kata-mount idempotency check (enableKataMount /
IsVolumeMountedByID) in NodeStageVolume to immediately after acquiring
the volume lock, matching upstream's ordering. If Kata already owns
the mount for this volume, NodeStageVolume must short-circuit before
any PV lookup or QAD/LUN resolution, since none of that work is
needed once Kata is verified to hold the mount.

* chore: add feature gate for qad - NodeDrivenAttachDetach

* chore: add more scoping for feature gate

* chore: remove win feature gate, optimize pv lookup and unblock static pv

* chore: add helm pkg

* chore: add fallback to volume context, change annotation updates

* chore: remove volume context fallback for qad check

* chore: remove qa... (continued)

Coverage Stats

598 of 1007 new or added lines in 10 files covered. (59.38%)

1 existing line in 1 file now uncovered.

5738 of 7731 relevant lines covered (74.22%)

13.81 hits per line