aio-libs / multidict / 35794352039

87%

push

github

Drop the unused get_mod_state_by_cls() helper (#1520)

<!-- Thank you for your contribution! -->

## What do these changes do?

`get_mod_state_by_cls()` in `multidict/_multilib/state.h` has no call
sites anywhere in the tree, so it is removed. Module state is reached
through `get_mod_state()`, `get_mod_state_by_def()` and
`get_mod_state_by_def_checked()` everywhere in the extension. Dropping
the helper also leaves `PyType_GetModuleState()` with no remaining
user; no include becomes unnecessary, since `state.h` gets that
declaration from `Python.h`.

C extension only; the pure-Python backend has no equivalent and needs
no matching change.

## Are there changes in behavior for the user?

No. The helper was never reachable from Python.

## Is it a substantial burden for the maintainers to support this?

No, it removes code.

## Related issue number

None. Split out of #1518 so that pull request stays one logical change.

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist — N/A, removal of dead code with
no behaviour to test
- [ ] Documentation reflects the changes — N/A, the helper was internal
and undocumented
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` — N/A, no such file in this repo
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Opus 5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Verification that the helper is unreferenced:

```
$ grep -rn "get_mod_state_by_cls" .
CHANGES/1520.misc.rst:1:Removed ``get_mod_state_by_cls()``, an unused helper in the C extension
```

(only the news fragment, after the deletion). `grep -rn
"PyType_GetModuleState"` over `*.c`/`*.h` excluding the vendored
`pythoncapi_compat.h` returns nothing afterwards.

Both backends, run after rebasing onto `1cdd934` ... (continued)

765 of 1530 branches covered (50.0%)

Branch coverage included in aggregate %.

6860 of 7147 relevant lines covered (95.98%)

1.92 hits per line