solidjs / solid / 35791406441

74%

main: 89%

push

github

fix(signals): cleanups run in unwind order — later registrations first, children before owner (#3572) (#3591)

`runDisposal` (client) and `disposeOwner` (server facade) now iterate an
owner's `_disposal` list in reverse registration order. Children were
already disposed before the owner's own cleanups; this restores the 1.x
LIFO rule from #1562 (8d0877e4) that 2.0's forward walk regressed.

In production a component body shares its enclosing owner (no
per-component owner), so with LIFO a parent that registers `onCleanup`
before rendering its children now tears down after them — matching the
dev tier's per-component owner (#3572).

Documented divergences that remain: a parent registering `onCleanup`
after creating its children, and a parent effect-returned cleanup vs a
child body's `onCleanup`.

Tests: new unwind-order pins in signals (source + all three dist tiers),
the server facade, and the flattened-vs-wrapped component shapes in
solid; two tests that pinned the old FIFO order incidentally are updated.

Co-authored-by: Claude via Cursor <noreply@cursor.com>

550 of 818 branches covered (67.24%)

Branch coverage included in aggregate %.

824 of 1070 relevant lines covered (77.01%)

17.53 hits per line