Bynder / bynder-java-sdk / 35790452214

40%

master: 40%

Build Type

Pull #158

github

Committed by ahongbynder

Commit Message

API-2971: fix socket timeout and OOM on large file uploads

- Thread HttpConnectionSettings through the Amazon S3 upload client
  (ApiFactory, AmazonS3Service/Impl, FileUploader, AssetService/Impl,
  BynderClientImpl) so upload timeouts are configurable instead of
  silently defaulting to OkHttp's hardcoded 10s connect/read/write
  timeouts, which caused SocketTimeoutException on large file uploads.
- Fix RXUtils.mapWithIndex to pair chunks with their index via a lazy
  map instead of zipWith(Observable.range(...)), which greedily drained
  the entire file into memory before any chunk was uploaded, causing an
  OutOfMemoryError on multi-gigabyte files.
- Switch FileUploader's chunk upload from flatMapSingle to
  concatMapSingle to process chunks strictly one at a time.
- Update HttpConnectionSettingsTest to match the new default timeout.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #158: API-2971: OutOfMemoryError: java heap space assetService.uploadFile

Coverage Stats

17 of 30 new or added lines in 8 files covered. (56.67%)

2 existing lines in 2 files now uncovered.

805 of 2009 relevant lines covered (40.07%)

0.4 hits per line