roocs / clisops / 35783733992
87%

DEFAULT BRANCH: master
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
35783733992

push

github

web-flow 
Fix `check_lons` and `convert_lat_lon_to_da` decorators (#512)

<!--Please ensure the PR fulfills the following requirements! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes issue #xyz
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Documentation has been added / updated (for bug fixes / features)
- [x] HISTORY.rst has been updated (with summary of main changes)

### What kind of change does this PR introduce?: <!--(Bug fix, feature,
docs update, etc.)-->
Previously, the `check_lons` would systematically call `np.asarray(lon)`
on `lon` arguments if it wasn't None. This had the effect of downcasting
a `DataArray` to a numpy array. Further down the line, in
`convert_lat_lon_to_da`, the arguments were re-casted to `DataArray`.
The overall effect for `subset_gridpoint` was that 1D arrays of
longitudes had their dimension name changed to `site` by this dance. The
dimension name preservation was not tested, I added a test.

Second issue was that `convert_lat_lon_to_da` did not ensure that 0D
input DataArrays were expanded to 1D, which seems to be a requirement of
`subset_gridpoint`. This issue was not detected by the tests because of
the one above.

### Does this PR introduce a breaking change?: <!--(Has there been an
API change? New dependencies?)-->
Not really, but now the dimension name is preserved in
`subset_gridpoint`.

### Other information: <!--(Relevant discussion threads? Outside
documentation pages?)-->
I didn't mean to push the modification of test `test_time_start_only` at
first, but oups. I was just surprise that a whole test was skipped with
a `>=` version condition, meaning it wouldn't be tested anymore in the
future. As the unwanted warnings came from xarray, I simply added a
condition on xarray's version. One smart observer could realize that
this minimum xarray version is the same as the maximum in the
dependencies.

I was also surpri... (continued)
Source Files on build 35783733992
Detailed source file information is not available for this build.