solidjs / solid / 35774262131

74%

main: 89%

push

github

fix(signals): a reawakened lazy memo rejoins its owner's chain (#3555)

* fix(signals): a reawakened lazy memo rejoins its owner's chain (#3554)

unobserved() splices an auto-dispose memo out of parent._firstChild when
its last subscriber leaves, but the reawaken in prepareComputed only
recomputed it. The node then ran live outside the chain with a null
_prevSibling and a stale _nextSibling, so its next dormancy took the head
branch of the splice and wrote the stale pointer into parent._firstChild,
orphaning every sibling created after it (still subscribed, still running
after the root's dispose()). Dev builds threw the owner-chain-head
invariant from #3552 mid-flush instead.

The reawaken now links the node back at the chain head before the
recompute, through the same linkChild helper createOwner and
setupComputedNode use for the creation-time link. A zombie is not
relinked: disposeChildren skipped its splice, so it still sits on the
parent's pending chain. Core floor 25,671 -> 25,684 bytes.

Claude-Session: https://claude.ai/code/session_01JH7R7yDguTxuXpDioMzMCT
Co-Authored-By: Claude <noreply@anthropic.com>

* fix: address review findings (round 1)

A dormant lazy memo read after its owner's dispose() is no longer linked
into that owner's child chain. disposeChildren skips the dormancy splice
when the parent is already REACTIVE_DISPOSED, so a relinked node stayed at
the head and the next reawaken linked it to itself, which sent markDisposal
and DEV.getChildren into an endless loop; the dead chain is also never
drained again, because dispose() early-returns on REACTIVE_DISPOSED.

linkChild resets node._prevSibling itself instead of relying on the caller
having cleared it. Core floor 25,684 -> 25,716 bytes, under the 25,750 cap.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: address review findings (round 2)

A lazy memo a cleanup reawakens while its owner's held children are torn
down stays on the owner's chain. recompute drains those child... (continued)

550 of 818 branches covered (67.24%)

Branch coverage included in aggregate %.

824 of 1070 relevant lines covered (77.01%)

17.44 hits per line