aio-libs / multidict / 35772873630

87%

push

github

Drop dead code from htkeys_build_indices() (#1516)

<!-- Thank you for your contribution! -->

## What do these changes do?

`htkeys_build_indices()` cannot fail; it always returned `0`. Both
callers, `_md_resize()` and `_md_shrink()`, tested for a negative
result and had an error branch that could never be taken. The function
now returns `void` and the callers invoke it directly.

The dead branch in `_md_resize()` was also mildly wrong on its own
terms: it returned `-1` without freeing the freshly allocated
`newkeys`.

Pure Python is unaffected; it has no equivalent of the C hash table's
index array.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes code.

## Related issue number

None.

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist N/A, no behaviour change; the
existing suite covers both callers
- [ ] Documentation reflects the changes  N/A, internal helper
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Opus 5); reviewed by :user:`asvetlov`.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Built and tested in an isolated venv on CPython 3.14.7t.

Build: `MULTIDICT_DEBUG_BUILD=1 pip install -e .` compiles clean under
`-Werror -Wsign-compare -Wconversion`.

Tests (C extension): `pytest tests -q` gives 2159 passed, 32 skipped.
Hypothesis leg: `pytest tests -q -m hypothesis` gives 143 passed, 4
skipped.
Tests (pure Python): `MULTIDICT_NO_EXTENSIONS=1 pip install -e . &&
pytest tests -q`
gives 2159 passed, 23 skipped.

Lint: pre-commit ran on both commits; clang-format passed, everything
else skipped for lack of matching files.

Docs: `make doc-spelling` build succeeded.

</details>

765 of 1530 branches covered (50.0%)

Branch coverage included in aggregate %.

6769 of 7053 relevant lines covered (95.97%)

1.92 hits per line