solidjs / solid / 35748247012

74%

main: 89%

push

github

fix(signals): LOADING_ON_OUTSIDE_HOLD reports only the same-source outside read (#3540) (#3584)

* fix(signals): LOADING_ON_OUTSIDE_HOLD reports only the same-source outside read (#3540)

The DEV diagnostic fired in two shapes. Only the first is sound:

- At the change, same source (kept): `on` re-arms the boundary while the
  very async source it is waiting on is also read by a live reader outside
  it, so the frame is held on that source and the fallback can never be
  seen. Deterministic and structural; `data.source` names the source and
  the fix is to move the outside read under the boundary. The message now
  states that claim; `latest()` in `on` stays a parenthetical capability
  (#3578 ruling).

- After the fact (removed): the frame was held — by the write's action, or
  by other pending data — past the content's landing, so the staged swap
  was cleared before display. That is a race the developer does not
  control (the nested boundary's data may simply be faster than the frame's
  hold) and a fallback that loses it is a legitimate outcome, not a defect.
  The engine cannot distinguish "the action awaited exactly this data" from
  "the action awaited something else that happened to be slower", so the
  rule is unsound.

Removed with it: `devHeldSweep`, `CollectionQueue._swapUnseen` and
`_devHeldSweep`, the `_checkSources` DEV drop, and the scheduler's DEV-only
parked-finalize walk (`devSweepBoundaryChildren`). `_settled`, `_judgeHeld`
and `_output` stay — they carry the pre-verdict boundary judgment (#3581).
Prod core floor unchanged (boundaries.ts is shed from that fixture; the
scheduler branch was DEV-folded); core+Loading −9 B prod, −647 B dev.

Tests: the after-the-fact pins flip to "not reported" (frame-following 5.,
rearm-reveal held-action cases, the web held-action spec); the same-source
pins tighten on the new message; one new pin for a frame held by OTHER
pending data that outlasts the content with no action — no report, the
conten... (continued)

550 of 818 branches covered (67.24%)

Branch coverage included in aggregate %.

824 of 1070 relevant lines covered (77.01%)

17.45 hits per line