mozilla-releng / balrog / #5756

90%

Build Type

push

circleci

Committed by jcristau

Commit Message

Bug 2065063 - Inherit required signoffs from Releases served by reference

A leaf Release named in a systemaddons SuperBlob's "blobs" list is what the
public app actually serves when a Rule maps to that SuperBlob, but no Rule maps
to the leaf's own name. Signoff discovery keyed on Rule mappings therefore found
nothing for it, and it could be rewritten with zero signoffs even though the
SuperBlob delivering it required them.

Maintain a release_references table (name -> referenced) as a reverse index,
populated whenever a Release is written and backfilled by alembic migration
0002, and union the Required Signoffs of any referrer's mapping Rules onto the
referenced Release. Scanning and parsing every Release's blob on each write was
the obvious alternative, but the legacy releases table stores whole blobs in one
column, so the LIKE prefilter it needs reads hundreds of MB per write.

Edges come from Blob.getResponseBlobs(), the method the public app itself calls
to decide what to expand and serve in place of the mapped Release, so the index
tracks serving behaviour by construction. Deliberately not
getReferencedReleases(), which also reports partial-update sources: a partial's
"from" Release is only compared against the incoming update query to decide
whether that partial applies, and none of its data reaches the response, so
editing one can at most move a client between the partial and the complete its
referrer already offers. It does not need the referrer's signoffs.

Coverage Stats

2218 of 2606 branches covered (85.11%)

Branch coverage included in aggregate %.

85 of 91 new or added lines in 1 file covered. (93.41%)

34 existing lines in 1 file now uncovered.

5856 of 6375 relevant lines covered (91.86%)

0.92 hits per line