hyperledger / fabric-x-committer / 35738939178

91%

Build Type

push

github

Committed by web-flow

Commit Message

[loadgen] Use the quick ASN.1 marshal for the transaction digest (#832)

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- `utils/testsig`'s endorser builds its digest with
`TxNamespace.QuickASN1Marshal` instead of
  `ASN1Marshal`.

The verifier's call site in `utils/signature/verify.go` is deliberately
left on `ASN1Marshal`,
as the issue scopes it. That is also what makes the change
self-checking: the verifier
recomputes this digest independently of the signer, so the two encoders
have to agree byte for
byte, and `service/verifier`'s tests sign through this endorser and
verify through the
reference path.

#### Additional details (Optional)

`ASN1Marshal` still reflects over an intermediate struct tree in the
pinned fabric-x-common —
`QuickASN1Marshal` is a separate exported method rather than a delegate
— so the issue's
condition for closing it as unnecessary does not hold.

#### Related issues

- resolves #813
- related to hyperledger/fabric-x-common#180

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

22 existing lines in 9 files now uncovered.

9552 of 10528 relevant lines covered (90.73%)

11245.41 hits per line