resoluteworks / invirt / #227

92%

Build Type

push

other

Committed by cosmin-marginean

Commit Message

Carry the handler's Cache-Control onto the error page (5.5.1)

ErrorPages renders a fresh response for a mapped status and, until now, kept only the handler's Set-Cookie headers. The caching directive says how the outcome of the request may be reused, not what the body looks like, so it comes across too: a handler that answers a miss with no-store means the miss, and a CDN that receives a rendered 404 with no directive pins it with its own defaults for hours.

Basecamp: https://app.basecamp.com/6162313/buckets/46188280/card_tables/cards/10326176900

Coverage Stats

519 of 588 branches covered (88.27%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

25 existing lines in 6 files now uncovered.

1689 of 1808 relevant lines covered (93.42%)

0.93 hits per line