solidjs / solid / 35711932302

74%

main: 89%

push

github

fix(signals): a boundary whose fallback is pending reveals landed content without waiting for the fallback's flight (#3540) (#3581)

* test(signals): pin what an on= re-arm does not license (#3540)

Reveal-timing and fallback-pending pins for re-armed Loading boundaries.
One pins a live defect: a re-armed boundary whose fallback is itself not
ready does not reveal landed content until the fallback's read lands.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(signals): re-derive the on= reveal-timing pins under frame-following (#3540, #3575)

The two reveal-timing pins were written against #3556's mainline swap. Under
#3575 the swap is staged into the notifying write's transaction, and the
boundary's output is that frame's from then on:

- staged source: the action outlasts the data, so old content holds through
  the flight, `data 2` lands at the commit, the fallback is never shown, and
  LOADING_ON_OUTSIDE_HOLD reports once after the fact.
- independent source: the content's own hold (the pending write it derives
  from) is joined to the action's frame when the staged output pass reads
  its landing — reveal at the commit, no fallback, same diagnostic. The
  pre-#3575 sequence is the display-ahead read's (`latest()`), pinned
  beside it.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(signals): judge a boundary whose fallback is pending before the verdict (#3540)

A collecting Loading boundary whose FALLBACK read something not ready left
its output pass pending on that read; an initialized parent held the frame
on it. When the content landed, the boundary was ready — but its output pass
derives from `_disabled`, not the tree, so the tree settling never re-ran
it; only the boundary sweep does, and that sweep ran at the commit
(finalizePureQueue), after the verdict the output's own read kept parking.
The content waited for the fallback's flight.

Judge that one shape before the ver... (continued)

550 of 818 branches covered (67.24%)

Branch coverage included in aggregate %.

824 of 1070 relevant lines covered (77.01%)

17.43 hits per line