hyperledger / fabric-x-committer / 35705135807

91%

Build Type

push

github

Committed by web-flow

Commit Message

[BREAKING] [sidecar] Unify sidecar RPCs into SidecarService, keep Fabric Deliver (#808)

#### Type of change

- Improvement (improvement to code, performance, etc)
- Bug fix
- Breaking change

#### Description

- Register a single `committerpb.SidecarService` in
`Service.RegisterService`,
replacing the separate `BlockQueryService` and `Notifier` registrations.
- Embed `*notifier` in `Service` and `UnimplementedSidecarServiceServer`
in
`notifier`, so selector depth promotes the block-query methods, the
stream
  methods, and the not-yet-implemented fallbacks onto one object without
  forwarder methods.
- Keep Fabric block delivery on the Fabric `protos.Deliver` service, a
separate
  gRPC service, so Fabric clients dial the sidecar unchanged.
- Move clients to `NewSidecarServiceClient`, and consume the renamed
upstream
block stream API (`StreamBlocks`, `StreamBlocksRequest`, `BlockEvent`),
  including `block_hash` and `prev_block_hash`.
- `StreamBlocks` now emits every committed block, including blocks whose
  filters match no transactions.
- `DeleteDBCloneForSnapshot` is reachable and answers `UNIMPLEMENTED`
until its
  pipeline lands.
- Guard the delivery session's config blocks behind
`configState.configBlock()`: the
embedded `*ConfigBlockMaterial` is nil until the first config block is
processed, so
`ToQueue` panicked when a session ended before that (also fixes the same
nil deref in
  the genesis-block comparison).

#### Additional details (Optional)

Requires the fabric-x-common release containing the unified
`SidecarService`
(hyperledger/fabric-x-common#179), pinned here as
`v0.2.9-0.20260910095823-4b946650f960`.

`UnimplementedSidecarServiceServer` is embedded on `notifier` rather
than on
`Service` on purpose: embedding it on `Service` would put it at the same
selector depth as the notifier's stream methods, making those selectors
ambiguous so `Service` would silently stop satisfying
`SidecarServiceServer`.

#### Related issues

- resolves #659

... (continued)

Coverage Stats

19 of 19 new or added lines in 5 files covered. (100.0%)

26 existing lines in 7 files now uncovered.

9512 of 10504 relevant lines covered (90.56%)

14430.51 hits per line