trixi-framework / Trixi.jl / 35693556951

97%

push

github

Fix `calc_depressed_cubic_roots` used by `PositivityPreservingLimiterLiuZhang` (#3259)

* Fix three-root trigonometric formula in calc_depressed_cubic_roots

The depressed cubic solver used sqrt(-p/3) in the acos argument instead of
sqrt(-3/p) from the Liu et al. reference implementation, causing DomainError
and incorrect momentum roots in Euler admissible projection. Add regression
tests for (p, q) = (-12, 10) and (-12, 3).

Co-authored-by: Cursor <cursoragent@cursor.com>

* Apply batched suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* remove extraneous comment

* avoid recomputing sqrt

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

1 of 1 new or added line in 1 file covered. (100.0%)

50887 of 52636 relevant lines covered (96.68%)

42066581.47 hits per line