akvo / isco / 34256231-3dcb-409f-86d0-4f2e7f16d114

86%

main: 86%

Pull #675

semaphore

[#674] Send mail over SMTP instead of through Mailjet

Transactional email went out through the Mailjet v3 REST API and the
Mailjet account is not delivering. Replace the client with the standard
library: `smtplib` plus `email.message.EmailMessage`. The environment
variable names match the Django projects in the other Akvo repositories,
so deployment wiring stays consistent across them.

The settings are read with `os.environ.get` rather than `os.environ[...]`.
The Mailjet credentials were read at import time, so the whole backend
failed to start when they were absent; now development and test
environments boot without a relay configured. Defaults describe the
common correct relay -- port 587 with STARTTLS on and implicit SSL off --
so a deployment that supplies only a host and credentials lands on a
working configuration. Neither TLS mode is inferable from the port
number, and picking the wrong one opens a plaintext socket against a
TLS-only port, which is what the timeout constant now bounds; the Mailjet
client bounded it at nothing at all.

`Email.data` returns an `EmailMessage` carrying a plain-text body with an
HTML alternative instead of Mailjet's payload dict. The rendered HTML
moves to its own `Email.html` property because the `/template/email`
preview endpoint read it back out of the payload under a key that no
longer exists. The `UserRecipient` shape is unchanged, so no call site in
`routes/` moves.

Three subjects in `util.i18n` are bilingual and written as triple-quoted
strings wrapped across source lines, so they carry a literal newline and
its indentation. Mailjet's JSON payload accepted that; a header may not
contain a linefeed. The subject is collapsed in the mailer rather than
rewritten in `util.i18n`, so the next bilingual subject someone wraps
does not reintroduce the failure.

The module-level `send(data)` helper and the `format_attachment` /
`attachment` path are dropped. Nothing called them, and porting the
attachment path to MIM... (continued)

2033 of 2517 branches covered (80.77%)

Branch coverage included in aggregate %.

5567 of 6273 relevant lines covered (88.75%)

0.89 hits per line