source-academy / js-slang / 35675681615

86%

push

github

fix(conductor): don't crash the error reporter on a non-SourceError (#2080)

`context.errors` is typed `SourceError[]`, but js-slang does not always keep
that promise. The CSE machine's `evaluateImports` pushes whatever `evaluate`
threw, and for an unresolved import that is a raw `TypeError` — reading
`context.nativeStorage.loadedModules['rune']`, which is `undefined` because
nothing loads modules under Conductor yet.

`toConductorError` then called `explain()` on it and threw *from inside the
error reporter*. On `SourceCseEvaluator.evaluateChunk`'s catch path that
replaced the student's diagnostic with `error.explain is not a function`
and lost the original failure entirely, so a §3 program containing

    import { black } from "rune";

reported nothing useful at all.

Falls back to `unknownToConductorError`, which already handles an arbitrary
thrown value. This is hardening, not the fix for module support — that is
tracked separately.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

2230 of 2724 branches covered (81.86%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

4389 of 5068 relevant lines covered (86.6%)

306998.63 hits per line