antchfx / xpath / 35672739326

84%

master: 84%

Pull #141

github

Return false from matches() when the node-set argument selects nothing

starts-with, ends-with and contains all return false when their node-set
argument selects no node (func.go:354, :381, :408). matches() returned ""
instead, so a boolean function handed back a string.

notFunc has no case for string and falls through to its default, so
not(matches(//no-such, 'x')) answered false where the three siblings answer
true. Idiomatically //a[not(matches(@href, '^https'))] dropped every <a> with
no href. boolean(X) and not(not(X)) also disagreed for the same X.

asBool maps "" to false, which is why a bare predicate looked right and this
went unnoticed.

1 of 1 new or added line in 1 file covered. (100.0%)

2535 of 3012 relevant lines covered (84.16%)

311.14 hits per line