cenkalti / rain / 35666653713

42%

Build Type

push

github

Committed by web-flow

Commit Message

Do not cancel the stopped event announce while closing a torrent (#248)

* Do not cancel the stopped event announce while closing a torrent

close() starts the stopped event announcer via stop() and closes it on the
next line, which cancels the announce context before the request can be
sent. Trackers therefore never learn how many bytes were uploaded since the
last periodical announce. A torrent that is removed shortly after it starts
seeding loses almost all of its reported upload.

Leave the announcer running instead. It only needs the tracker.Torrent
snapshot it was created with, and it stops by itself when TrackerStopTimeout
expires. Buffer announcersStoppedC so the announcer can deliver its result
and exit after the torrent run loop is gone.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Cancel the stopped event announce context when announcing is done

Run creates a context with a deadline and a goroutine that waits for either
the deadline or Close. Nothing cancelled the context when announcing
finished first, so that goroutine stayed alive until the deadline expired.
It went unnoticed while every announcer was closed right after starting.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

7 of 7 new or added lines in 3 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

4979 of 12059 relevant lines covered (41.29%)

47.54 hits per line