eclipse-aascw / aas-core-codegen / 35664589463

89%

Build Type

push

github

Committed by web-flow

Commit Message

Check the membership in a JSON-able object (#741)

An invariant may well ask whether a JSON-able object carries a key, and
the type inference has always allowed it, but the transpilation did not
follow.

The membership check is now decided on the inferred type of the container,
in all the six backends:

* C++ asks ``nlohmann::json::contains``, with the key converted to UTF-8,
  as a string in the transpiled code is a wide string;
* C# asks ``Nodes.JsonObject.ContainsKey``;
* Java asks ``ObjectNode.has``;
* Golang asks ``aascommon.MapContains``, the same as it does for a set,
  a JSON-able object being a ``map[string]interface{}``;
* TypeScript asks ``Object.prototype.hasOwnProperty.call``, so that an object
  which carries a key ``hasOwnProperty`` of its own does not shadow the check;
* Python already spelled it ``in``.

A membership in a JSON-able *value* or *array* is refused with a message
instead of the wrong code which C++, C# and Java used to generate for it.

The new test case ``json_types_in_invariants`` covers the membership in
a JSON-able object and in an optional one, so that the de-referencing of
an optional is exercised as well.

Coverage Stats

20 of 23 new or added lines in 6 files covered. (86.96%)

1 existing line in 1 file now uncovered.

36849 of 42273 relevant lines covered (87.17%)

2.62 hits per line