pulibrary / lib_jobs / 745aca09-8a40-4d15-a1ce-4b1e405cb937

98%

push

circleci

Add optin contact info (#1221)

* Add field Opt-In Contact Info

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>

* Update test data to get tests passing

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>

* Update email, pul:Address, pul:Building, and University Phone to empty string
when the opt in contact field is false

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>

* Remove memoization of CSV output

Since we moved to Hanami's dependency injection, we only have a single instance of the
CSV builder.  Prior to this commit, we memoized the CSV data within the object, so
we got the exact same data every time we called the builder.

Here we remove the memoization so we can get fresh data each time.

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>

* Address rubocop

---------

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Jane Sandberg <js7389@princeton.edu>
Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>

12 of 12 new or added lines in 2 files covered. (100.0%)

3712 of 3776 relevant lines covered (98.31%)

1164.73 hits per line