gladiaio / words2num2 / 35655459227
61%

DEFAULT BRANCH: main
Ran
Jobs 6
Files 6
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.459%. Remained the same
35655459227

push

github

web-flow 
fix(en): a tens word may not follow a smaller number (#21)

Resolves #17.

English composes a tens word with a FOLLOWING unit - 'sixty three' is
63 - never with a preceding one. 'three sixty' is two numbers read in
sequence, not 3 + 60, and 'twenty twenty' is two twenties, not 40.

cardinal_value accumulated both orders, so:

  three sixty           -> 63    now two runs: '3 60'
  three sixty five      -> 68    now '3 65'
  nineteen eighty four  -> 103   now '19 84'
  twenty twenty         -> 40    now '20 20'

Tracking whether the sub-hundred slot of the current chunk is already
occupied, and rejecting a tens word when it is, produces both behaviours
from one change: the sentence walker grows the longest run that parses,
so a rejected continuation simply starts a new run.

'hundred' and the scale words close the slot, so 'one hundred sixty'
(160), 'three hundred sixty' (360) and 'two thousand sixty' (2060) are
untouched. The year path is reached before cardinal_value, so the pair
reading stays where it belongs: to='year' still gives 1984 and 2020.

words2num() raises for these inputs - a single number was asked for and
two were given - which is what every other malformed cardinal does.

573 + 29 Rust and 133 Python tests pass; adds 17 covering the four
changed readings, the compositions that must not move, and the year
path.

Co-authored-by: Jean-Louis Queguiner <jean-louis.queguiner@gmail.com>

44 of 74 relevant lines covered (59.46%)

3.54 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3.14 - 35655459227.1 6
58.9
GitHub Action Run
2 3.13 - 35655459227.2 6
59.46
GitHub Action Run
3 3.15 - 35655459227.3 6
58.9
GitHub Action Run
4 3.12 - 35655459227.4 6
59.46
GitHub Action Run
5 3.11 - 35655459227.5 6
59.46
GitHub Action Run
6 3.10 - 35655459227.6 6
59.46
GitHub Action Run
Source Files on build 35655459227