aio-libs / multidict / 35640840634

87%

push

github

Add getall benchmarks for keys with many values (#1509)

<!-- Thank you for your contribution! -->

## What do these changes do?

Adds three CodSpeed benchmarks for `getall()` on keys with many values,
to give #1505 a baseline on paths the current benchmarks miss.

After #1505, `getall()` keeps up to 8 matches in a short inline list and
only then starts a bitmap, which lives in a 4 KB inline buffer (32768
entries) and moves to the heap for bigger tables. The existing
`test_multidict_getall_str_hit_large_table` has 8 values per key, so it
no longer reaches the bitmap at all.

* `test_multidict_getall_str_hit_large_table_many_values`: 16 values per
key over 4096 keys (65536 entries), 128 lookups per run; covers the heap
bitmap.
* `test_multidict_getall_str_hit_many_values`: 64 values per key over 16
keys (1024 entries), each key looked up 8 times per run; covers the
inline bitmap.
* `test_cimultidict_getall_istr_hit_many_values`: the
`CIMultiDict`/`istr` twin of the previous one.

## Are there changes in behavior for the user?

No, benchmarks only.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

Related to #1505

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, benchmarks only
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Isolated venv on CPython 3.13.2, based on upstream/master 1ccffea.

C extension: `pytest tests/test_multidict_benchmarks.py -q`: 197 passed.
Pure Python (`MULTIDICT_NO_EXTENSIONS=1`, `--no-c-extensions`): 100
passed, including all new cases.
`pre-commit run` on changed files: passed. `make doc-spelling`: build
succeeded.
... (continued)

762 of 1524 branches covered (50.0%)

Branch coverage included in aggregate %.

28 of 28 new or added lines in 1 file covered. (100.0%)

6616 of 6897 relevant lines covered (95.93%)

1.92 hits per line