wegamekinglc / Derivatives-Algorithms-Lib / 35628076446

92%

push

github

chore: address residual review findings across the stack (#411)

* Restrict LSMC regression and exercise decisions to ITM paths

Classic Longstaff-Schwartz regresses the continuation value on the
in-the-money paths (h > 0) only. Including every condition-true path let
deep-OTM (h == 0) paths into the fit, and a regression that undershot
below zero then "exercised" worthless options: on a two-date 90 put the
unfiltered driver exercised 41% of all paths at the mid date against a
25% ITM fraction and underpriced by more than 1% versus the PDE oracle.

FillIncluded now intersects the condition row with h > 0, PathPayoff
requires a strictly positive exercise value, and the fuzzy replay blends
the decision degree with the one-sided CSpr(h, 0, eps) ramp so the blend
converges to the corrected hard rule (degree 0 on the h == 0 atom; a
centered ramp would leave 0.5 there). The empty regression set also
carries the sigma floor now: a count-0 day previously kept sigma_ == 0
and produced NaN continuations in the fuzzy replay's z-normalization.

num_cond_true_paths in the simulation diagnostic accordingly reports the
ITM condition-true count; the dal-public and dal-excel pins move to the
measured values and the dal-python assertion to the semantic bound.

* Anchor the Bermudan PDE s=0 boundary at the next exercise date

During the rollback over (t_e, t_{e+1}] the boundary was
K*exp(-r*(t_e - t)) >= K, anchored one exercise period back; the
Bermudan value at s = 0 is K*exp(-r*(t_{e+1} - t)), anchored at the
segment's right endpoint, exactly as the final segment already did. The
loop now passes the current tNext (read before rollTo reassigns it).

Measured delta on every suite benchmark is exactly zero: the boundary
layer is a few grid cells deep inside the payoff-floored region, and the
projection at each exercise date overwrites precisely that layer, so the
mis-anchoring never reached an interpolated value; the final segment,
the only one whose boundary survives t... (continued)

14 of 15 new or added lines in 5 files covered. (93.33%)

15349 of 16740 relevant lines covered (91.69%)

3250699.86 hits per line