OpenModelica / modelica-language-server / 35618359654

84%

Build Type

push

github

Committed by web-flow

Commit Message

Load library documents lazily instead of eagerly parsing every file (#83)

* Load library documents lazily instead of eagerly parsing every file

ModelicaLibrary.load() parsed and permanently retained a web-tree-sitter
syntax tree for every .mo file in every configured MODELICAPATH library at
startup. For a library the size of Buildings (thousands of files) this
exhausts the wasm parser's linear memory before the scan finishes, aborting
the whole process; reproduced with the real Buildings/MSL libraries, where
the second large library dies mid-scan and every library after that fails
instantly, matching OpenModelica/OpenModelica#16802 exactly.

Only the library root (package.mo) is now parsed eagerly, to register the
library's name/path. Individual documents are parsed on first reference,
via ModelicaLibrary.getOrLoadDocument, from both the async document-loading
path (ModelicaProject) and the synchronous symbol-resolution path
(resolveReference.ts, which already computed exact file paths and just did
a bare Map lookup rather than falling back to disk).

Also fixes several places that discarded or replaced a Tree without calling
tree.delete(): ModelicaDocument.update() on both the whole-document and
incremental-edit paths, ModelicaProject.removeDocument/removeLibrariesUnder,
and a discarded standalone-library guess in ModelicaProject.addDocument.
web-tree-sitter trees are backed by wasm linear memory that JS garbage
collection does not reclaim.

Fixes OpenModelica/OpenModelica#16802

* Document the library-loading and wasm memory-management design

Write up, in the server README, why library documents are loaded lazily
and the tree.delete() disposal contract decided while fixing #16802, so
it's not just implicit in the diff.

* Coordinate concurrent document loads and fix a TreeCursor leak

Lazy library loading (previous commit) made cold document loads routine
instead of rare, which turns a latent race in the cache-population paths
into a live one: Mo... (continued)

Coverage Stats

470 of 619 branches covered (75.93%)

Branch coverage included in aggregate %.

210 of 218 new or added lines in 5 files covered. (96.33%)

1 existing line in 1 file now uncovered.

3030 of 3871 relevant lines covered (78.27%)

13.08 hits per line