eclipsesource / jsonforms / 35616710560

85%

push

github

fix(react): add props.options to ctxToMultiEnumControlProps's options memo

ctxToMultiEnumControlProps memoized its options result with a useMemo call missing props.options from its dependency array, unlike its two siblings, ctxToEnumControlProps and ctxToOneOfEnumControlProps, which both correctly include it. mapStateToMultiEnumControlProps already reads ownProps.options as its own preferred source over deriving options from the schema, so this is a supported way to supply options externally 
Also widens the props parameter type from OwnPropsOfControl to OwnPropsOfControl & OwnPropsOfEnum, matching ctxToOneOfEnumControlProps - the narrower type was masking the missing dependency.

Added a regression test mounting a control through withJsonFormsMultiEnumProps asserting the rendered control picks up an update to that prop after mount.

Fixes #2624

12564 of 31934 branches covered (39.34%)

20378 of 24110 relevant lines covered (84.52%)

33.7 hits per line