php-bug-catcher / bug-catcher / 35607217185

86%

main: 94%

push

github

feat(mcp): let the tools read a custom record type

The finder rooted every query at RecordLog, so a record type an application
adds by extending Record directly was collected, shown on the dashboard, and
then invisible to the one reader that could act on it. A cron run that never
finished is exactly such a type, and exactly the thing worth handing to an
assistant.

Queries now root at Record and are narrowed by bug_catcher.mcp.record_types,
resolved to discriminator values by the new Mcp\RecordTypes and applied the way
LogList already does it. The default stays RecordLog and RecordLogTrace, so an
application that configures nothing sees no change.

Kept apart from dashboard_list_items on purpose. A token holder can resolve and
archive what it finds, so adding a type is a decision to take on its own, not a
side effect of putting it on a page. A class outside the discriminator map is
refused with an exception naming the ones that are in it - LogList drops unknown
classes silently, and that is precisely how this repository's own test app came
to list a class that does not exist (fixed here too).

Three consequences worth spelling out:

Record now answers getMessage(), getLevel() and getRequestUri() with null, so
every subtype has the shape the tools promise. Deliberately not #[Ignore]d: the
serializer merges attribute metadata down the hierarchy, so ignoring the getter
here also ignores the mapped property in RecordLog, and every ingest POST fails
validation as a blank message. Twenty tests said so.

minLevel cannot read record.level off a Record root - DQL has no TREAT() - so it
becomes a semi-join into RecordLog. That says the right thing as well: asking
for a level floor asks for the records that carry a level, so a cron run drops
out rather than passing itself off as level 0.

groups() sets HINT_FORCE_PARTIAL_LOAD, since a Record root LEFT JOINs every
subtype table and the aggregate reads none of them. representatives() must not:
those entities are ... (continued)

59 of 61 new or added lines in 4 files covered. (96.72%)

1166 of 1349 relevant lines covered (86.43%)

11.58 hits per line