Qiskit / qiskit-ibm-runtime / 35591323301

91%

main: 91%

push

github

Disable no_site_packages in mypy configuration (#3328)

### Summary

Update the mypy configuration in order to:
* take into account installed dependencies that provide type hints.
* revise specific rules for `test/`, so it steers us towards type
hinting auxiliary functions, and unify how imports are treated (now the
same as for the library)

### Details and comments

Some dependencies are still not taken into account (in
`[tool.mypy.overrides]`). With this PR, `mypy` will check the
dependencies that provided type stubs in the upstream package directly.
A number of the remaining ones also provide support through them in
`typeshed` or as other dedicated packages: I went with not including for
this round as it needs checking for versions compatibility and
accuracy/issues.

This also involves reverting the direction from #3156:
* with this change, `mypy` needs to have access to the dependencies
installed. With the current approach in `main`, it will run in an
isolated venv with just `mypy` installed - and no way for
`pre-commit.yml` to install the package and its dependencies.
* reverting to the "assume that `mypy` will be run in a venv managed by
the user" solves it, as users/CI control what to install before
invoking.
* `uv` users are likely to be able to replicate `pre-commit` behavior
via using `exec uv run pre-commit ...` when manually invoking, or
customizing their locally installed git hook
* the alternative to reverting is copy-pasting the dependencies into
`pre-commit.yml` - which is prone to keeping them out of sync

Related to #3295

### AI/LLM disclosure

- [x] I used the following tool to generate or modify code: Claude Opus
4.8 for some of the typing

1 of 1 new or added line in 1 file covered. (100.0%)

8629 of 9517 relevant lines covered (90.67%)

9.91 hits per line