zostera / django-marina / 35581785945

100%

push

github

Fail the CI gate when any job fails, not only the test matrix (#682)

* Fail the CI gate when any job fails, not only the test matrix

The tests job is the only required status check on main, and it only failed
when python_django_matrix failed. Because it runs with if: always(), a failing
lint, docs or build left it green, so a pull request with failing lint could
be merged. That was true in all five packages.

It now fails if any job it needs reports failure, cancellation, or a skip. No
job in this workflow is conditional, so a skipped need means something went
wrong upstream rather than a deliberate exclusion. The failing results are
printed so the cause is visible without opening each job.

The Coveralls finish step moves first. It used to sit after the matrix check,
which meant a matrix failure skipped it and left the parallel coverage build
open. Widening the gate would have made that happen on any failure.

The job id stays tests, since that is the required check context configured in
branch protection.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* ci: correct the gate comment about what was ungated

The comment claimed a failing lint could be merged. It could not. The matrix
needs lint, so a lint failure skipped the matrix, and the old condition treated
skipped as not success. Only docs and build were ungated, because neither feeds
the matrix.

The description on the pull request had this right; only the comment in the
workflow was wrong, and that is the copy that outlives the pull request.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* ci: shrink the gate step and say why needs alone will not do

Four env vars and four echo lines restated what toJSON(needs) prints on its
own, and they had to be edited by hand every time a job was added or renamed.
One NEEDS variable covers it, and prints job outputs too. It goes through env
rather than straight into run, so nothing from a job output is interpola... (continued)

28 of 28 branches covered (100.0%)

Branch coverage included in aggregate %.

164 of 164 relevant lines covered (100.0%)

16.0 hits per line